HeliumProject / Engine

C++ Game Engine (Under Construction!)
http://heliumproject.org/
Other
442 stars 70 forks source link

Cleaning dependencies does not clean everything on windows #48

Closed kevindqc closed 11 years ago

kevindqc commented 11 years ago

wxWidget was update and I couldn't compile it because of the following error: "wxUSE_PREFERENCES_EDITOR must be defined, please read comment"

I found that that my setup.h was missing wxUSE_PREFERENCES_EDITOR

I found that "Dependencies\wxWidgets\lib\vc_x64_dll" was not getting removed when I run "..\premake clean" in the Dependencies folder, and that's where setup.h was coming from

not sure if that's a problem with Helium or wxWidgets though ?

gorlak commented 11 years ago

premake's clean directive is to tidy up the generated project files that premake itself creates. Currently we don't even have premake generate project files to build wxwidgets. Instead we call into wxwidget's makefiles from premake.exe (but invoking make from premake.exe). As such, if you want to clean wxwidgets you will need to invoke 'make clean' from within wxwidgets manually. Alternatively you can cd into the wxWidgets submodule and use 'git clean -fdx' to delete files that git doesn't recognize (which includes the output of the build), which effectively cleans out what you probably want gone.

kevindqc commented 11 years ago

oh, I thought I had seen in wxWidget.lua that premake clean actually tries to call make clean

gorlak commented 11 years ago

Oh, hmm... perhaps. I will give a glance tomorrow.

-Geoff

On Jul 31, 2013, at 7:52 PM, Kevin Doyon notifications@github.com wrote:

oh, I thought I had seen in wxWidget.lua that premake clean actually tries to call make clean

— Reply to this email directly or view it on GitHub.

gorlak commented 11 years ago

You are correct that calling premake clean does invoke wx's make clean... however it seems their makefile's clean step aren't tidying up a bunch of stuff, I see manifest, pdb, as well as the setup.h file you mentioned are left behind after cleaning. I advise you use git clean for the short term. If it causes trouble in the future I guess we could rmdir the vc_XX_dll folders from the premake script...

kevindqc commented 11 years ago

Alright, thanks for checking!