search

HelixNetwork / pendulum

Pendulum is a distributed messaging protocol that enables globally available tamper proof timestamps :hourglass_flowing_sand:
https://dev.hlx.ai
Other
10 stars 6 forks source link

Fix isCandidateBundleStructureValid #115

Closed cristina-vasiu closed 5 years ago

cristina-vasiu commented 5 years ago

Problem was at bundle creation, the number of sender transaction was not computed correctly if the data was multiple of 512 bytes, because of this, for registration_bundle (with security level 1) bundle has 4 transaction instead of 3.

oracle58 commented 5 years ago

Codecov Report

Merging #115 into finality-update-2 will decrease coverage by 0.02%. The diff coverage is 0%.

Impacted file tree graph

@@                   Coverage Diff                   @@
##             finality-update-2     #115      +/-   ##
=======================================================
- Coverage                37.81%   37.79%   -0.03%     
  Complexity                1077     1077              
=======================================================
  Files                      172      172              
  Lines                     8433     8433              
  Branches                  1072     1072              
=======================================================
- Hits                      3189     3187       -2     
- Misses                    4886     4891       +5     
+ Partials                   358      355       -3
Impacted Files Coverage Δ Complexity Δ
...n/java/net/helix/hlx/utils/bundle/BundleUtils.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
src/main/java/net/helix/hlx/crypto/Winternitz.java 69.52% <0%> (-4.77%) 25% <0%> (-3%)
src/main/java/net/helix/hlx/network/Node.java 39.06% <0%> (+0.23%) 45% <0%> (+1%) :arrow_up:
...va/net/helix/hlx/network/TransactionRequester.java 58.73% <0%> (+3.17%) 17% <0%> (+2%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a6cb4e8...208068c. Read the comment docs.