HelixNetwork / pendulum

Pendulum is a distributed messaging protocol that enables globally available tamper proof timestamps :hourglass_flowing_sand:
https://dev.hlx.ai
Other
10 stars 6 forks source link

Empty round hashes should not be null_hash #184

Closed oracle58 closed 4 years ago

oracle58 commented 4 years ago

The null_hash should only be used as a genesis entry point, such that solidification always requests all branches and trunks, until we reach the actual genesis entry point. If empty rounds (empty latestSnapshots) result in null_hash, the solidification stops at those points and the protocol inherently considers these empty rounds as genesis entry points. Transactions previous to that empty round would not be requested anymore.

A fix would be to generate unique hashes for empty rounds.

oracle58 commented 4 years ago

Addressed with a temporary fix in this commit.