1.0.2

[oracle58]

• Added roundIndex to transaction meta data
• Set round indices of a round's txs in MilestoneTracker
• Removed obsolete isPoWDisabled setting
• Removed obsolete spammer-class
• Changed default dir of local snapshots from mainnet to snapshot
• Only debug log most recent applied round
• Fixed #184: NULL_HASH not used as empty round's snapshot hash anymore
• Temporarily added parameter NUM_OF_ACTIVE_VALIDATORS
• Temporarily added parameter CONFIRMATION_THRESHOLD
• Set roundIndex of all round's txs - not only milestones
• Update getConfirmedTransactions
• Added confirmations to tx meta data. Each time a valid milestone refers to a transaction this counter is incremented.
• New implementation of getConfirmationStates, which now compares relative confirmations to a specifiable confirmation threshold.

Remaining Issues

• https://github.com/HelixNetwork/pendulum/issues/196

• MilestoneTracker fails at the part where we would count confirmations: https://github.com/HelixNetwork/pendulum/blob/confirmation-state/src/main/java/net/helix/pendulum/service/milestone/impl/MilestoneTrackerImpl.java#L301

• After waiting for first VALID milestone I submit a value transaction, but balance seems to not always be updated (seems to be a general issue, could reproduce on dev - not related to PR)

• transaction.confirmations count is never incremented because https://github.com/HelixNetwork/pendulum/blob/confirmation-state/src/main/java/net/helix/pendulum/service/milestone/impl/MilestoneTrackerImpl.java#L301 fails

• if https://github.com/HelixNetwork/pendulum/blob/confirmation-state/src/main/java/net/helix/pendulum/service/milestone/impl/MilestoneTrackerImpl.java#L301 works we can todo: https://github.com/HelixNetwork/pendulum/blob/confirmation-state/src/main/java/net/helix/pendulum/service/API.java#L1778

• why is "testnet" dir still created, after I reset the LOCAL_SNAPSHOT_PATH ?

[dnck]

why is "testnet" dir still created, after I reset the LOCAL_SNAPSHOT_PATH ?

The LOCAL_SNAPSHOTS_BASE_PATH is used to store the plain txt files during a local snapshot.

[oracle58]

In the Testnet config, I think that LOCAL_SNAPSHOT_PATH is ignored. Instead, LOCAL_SNAPSHOTS_BASE_PATH is used, and so plain txt files from local snapshot end up being stored in the testnet dir.

Well, thats the one I mean:

String LOCAL_SNAPSHOTS_BASE_PATH = "./snapshot";

I think, I set it correctly, yet "testnet" dir is still created. Furthermore, I am bit surprised that only:

• snapshot.state
• snapshot.meta
• snapshot.gc

instead of:

• snapshot.state
• snapshot.meta
• snapshot.gc
• snapshot.state.bkp
• snapshot.meta.bkp

get created in this build, i.e. :

• snapshot.state.bkp
• snapshot.meta.bkp don't get created anymore.

[dnck]

Well, thats the one I mean:

String LOCAL_SNAPSHOTS_BASE_PATH = "./snapshot";

I think, I set it correctly, yet "testnet" dir is still created. Furthermore, I am bit surprised that only:

• snapshot.state
• snapshot.meta
• snapshot.gc

instead of:

• snapshot.state
• snapshot.meta
• snapshot.gc
• snapshot.state.bkp
• snapshot.meta.bkp

get created in this build, i.e. :

• snapshot.state.bkp
• snapshot.meta.bkp don't get created anymore.

I am running branch confirmation-state locally, and the .bkp files are generated when I provide a path to LOCAL_SNAPSHOTS_BASE_PATH in the config file.

[oracle58]

Well, thats the one I mean:

String LOCAL_SNAPSHOTS_BASE_PATH = "./snapshot";

I think, I set it correctly, yet "testnet" dir is still created. Furthermore, I am bit surprised that only:

• snapshot.state
• snapshot.meta
• snapshot.gc

instead of:

• snapshot.state
• snapshot.meta
• snapshot.gc
• snapshot.state.bkp
• snapshot.meta.bkp

get created in this build, i.e. :

• snapshot.state.bkp
• snapshot.meta.bkp don't get created anymore.

I am running branch confirmation-state locally, and the .bkp files are generated when I provide a path to LOCAL_SNAPSHOTS_BASE_PATH in the config file.

Ok, is the "testnet" dir still created?

[dnck]

Ok, is the "testnet" dir still created?

I can not reproduce.

When running with config,

TESTNET = true
LOCAL_SNAPSHOTS_BASE_PATH = local_snapshots

neither testnet nor mainnet dir is created.

When running with config,

TESTNET = false
LOCAL_SNAPSHOTS_BASE_PATH = local_snapshots

neither testnet nor mainnet dir is created.

[oracle58]

Ok, is the "testnet" dir still created?

I can not reproduce.

When running with config,

TESTNET = true
LOCAL_SNAPSHOTS_BASE_PATH = local_snapshots

neither testnet nor mainnet dir is created.

When running with config,

TESTNET = false
LOCAL_SNAPSHOTS_BASE_PATH = local_snapshots

neither testnet nor mainnet dir is created.

might be a local problem then, also cannot reproduce on an ubuntu 16.04 vm.