Hellenic / react-hexgrid

Build interactive hexagon grids with React
https://hellenic.github.io/react-hexgrid/examples/
MIT License
318 stars 130 forks source link

only wrap fill in url css function when url is detected #33

Open json2d opened 5 years ago

json2d commented 5 years ago

this lets you use colors with the fill prop:

<Hexagon fill={"red"}/>
<Hexagon fill={"#f00"}/>
<Hexagon fill={"http://foo.bar/some-image.jpg"}/>
jannikbuschke commented 2 years ago

@json2d I think it is actually better to remove the "smartness" of the Hexagon and just expose the api of the underlying component. Ill let this PR open to keep track of this issue, but have no intention to merge. Thanks for your effort, hope you will be ok with a slightly different solution.