Open Hellenic opened 2 years ago
Hi @Hellenic, I like this library, it is small and useful. I am not sure if I would qualify as a maintainer, but there are some things I would like to add, such as typescript support and storybook playground. Also I can imagine helping to advance the api and core implementation into newer react versions.
Sounds great! It would be great to see the library keep growing, so everyone wouldn't have to fork it for themselves :) Someone else contacted me as well. I will add both of you as contributors and let's take it from there.
Cool. Should we have a small chat or maybe video call, on which direction we would want to go and how to release new versions? I.e. probably with semantic versioning, but I also would like to publish beta versions. Can I just edit the .gitub actions and push to see if the pipeline still works?
I started to migrate the codebase to typescript, react function components and storybook: https://github.com/Hellenic/react-hexgrid/tree/add-typescript-and-storybook. I am not yet sure which direction to go with stylings and if I would want to break the api already or only in one of the next steps. And the testrunners I am also not sure, I have some experience with @testing-library/jest-dom, @testing-library/react, jest. Jest is already in use here, but I broke the tests and am not a huge fan of snapshot testing.
Do you have any feelings about replacing some libraries with the ones mentioned above? Maybe have a 10-20 chat/videocall?
Hey! Yeah we can have a call. Would following weekend work for you? Short call should be fine about anytime, feel free to send an invite
Overall I don't have strong feelings aout the direction though, I'm too short on time for that :D
Beta versions also sounds good. It might already even work, if you version it as beta in package.json
, push and run the action. Feel free to edit and try out
@jannikbuschke, can you let me know what you might need help on for the typescript branch? Can we set up a Discord for this project?
Can you set up a discord?
For the typescript branch I dont really need help, its basically done and I also already merged stuff on master. There are also already beta releases.
But we may want to align on the topics there. I tried to not break anything, but I actually would like to change some minor things and maybe also some component names. Maybe we can release a basically non-breaking v2 with typescript support and think about how a version 3 could look like.
Sounds good. @jannikbuschke, @Hellenic I set up a discord channel. The invite is below. https://discord.gg/6MbPU8Kv
Hello! The Discord links in the readme and here are invalid. I'm interested in maintaining this project! I've updated several outdated dependencies in my own fork (most notably upgrading the storybook version). Let's be in touch!
Hey all!
I'm very pleased to see that this library is being used somewhat widely and in different use cases. This library I wrote mostly for my personal prototyping but still published for the community to try out. Once it was "ready" for my use case, I didn't really bother to look back and moved on to different things. Currently I still don't have plans to develop it further or maintain it.
That being said, since it's still being used and I can see people actively starring and forking it, I'm happy to invite new maintainers to the project!
Happy to hear recommendations as well how this can be safely done, and how we can make sure the future releases of the library remain safe for users to use.