search

HelloThisIsFlo / Appdaemon-Test-Framework

Clean, human-readable tests for Appdaemon
https://hellothisisflo.github.io/Appdaemon-Test-Framework/
MIT License
45 stars 19 forks source link

Add warning on appdeamon 3.x #34

Closed lifeisafractal closed 4 years ago

lifeisafractal commented 4 years ago

This PR fixes #32 by adding a deprecation warning if run with appdaemon <4.0. It will report this warning only up to once per a test as follows:

test/integration_tests/tests/test_kitchen.py::TestClickCancellation::TestMixedClicks::test_long_then_short_keep_latest[Kitchen]
  /home/mcampbell/personal/lifeisafractal_github/Appdaemon-Test-Framework/appdaemontestframework/hass_mocks.py:23: DeprecationWarning: Appdaemon-Test-Framework will only support Appdaemon >=4.0.0 in the next major release. Your current Appdemon version is 3.0.5
    .format(self.min_supported_version, appdaemon_version), DeprecationWarning)

This PR also adds version constraints to the setup.py. I'm not familiar with using a Pipfile and Pipfile.lock, but I'm wondering if we should be using one or the other of these methods to constrain packages. Can you weigh in on that one?

Testing done locally

HelloThisIsFlo commented 4 years ago

@lifeisafractal I pushed a couple of commits. Let me know if you're ok with the changes, or start a review yourself (I think you can do that now right?). If all good, I'll merge :)

lifeisafractal commented 4 years ago

Looks ready to me, thanks for the work on cleaning things up!