search

HelloThisIsFlo / Appdaemon-Test-Framework

Clean, human-readable tests for Appdaemon
https://hellothisisflo.github.io/Appdaemon-Test-Framework/
MIT License
45 stars 19 forks source link

Fix bug python38 #40

Closed HelloThisIsFlo closed 4 years ago

HelloThisIsFlo commented 4 years ago

This pull request fixes #38 and implement a much cleaner way of mocking the arguments passed via the appdaemon config (accessible via the field args in any automation)

HelloThisIsFlo commented 4 years ago

UPDATE TO THE UPDATE: This does NOT actually break python 3.6. So we can release anytime :)

Update: This breaks compatibility with python 3.6

As agreed in #38 this is fine, but we will need to remember to do a MAJOR release when bumping the version. On another aspect, it also broke the travis build. I'm trying to figure out why and how to fix it. We might see a lot of "Try to fix Travis build" commits as . . . I don't know how to fix a CD problem without actually pushing to the CD system 😅 (if there's a way, I'd love to know)

HelloThisIsFlo commented 4 years ago

Ok, so I renamed this as a WIP. Because it's a bit more complex than I expected. It fails on python 3.8 on travis, but works fine locally :/ I'll look into it

HelloThisIsFlo commented 4 years ago

Ok, travis is passing and testing both python 3.7 and 3.8 😃

HelloThisIsFlo commented 4 years ago

@lifeisafractal You've approved. I'm merging 👍