fix include - Githubissues

HelloThisIsFlo / Appdaemon-Test-Framework

Clean, human-readable tests for Appdaemon

https://hellothisisflo.github.io/Appdaemon-Test-Framework/

MIT License

45 stars 19 forks source link

fix include #58

Closed fhoekstra closed 3 years ago

fhoekstra commented 3 years ago

I also took the chance to:

update python version in setup.py
increment version of the distribution, just to be sure

I tested it by building the wheel and re-running the tests after installing the wheel with pip, issue #57 was resolved afterward.

HelloThisIsFlo commented 3 years ago

Would this work without any arguments to find_packages?

Like this stackoverflow answer suggests.

fhoekstra commented 3 years ago

It probably does, but I think we may start shipping some of the folders in test then, if they have an __init__.py file. So that may be worth checking

fhoekstra commented 3 years ago

I just did that, renamed the resulting .whl file's extension to .zip and took a look inside. The result seems to be the same.

HelloThisIsFlo commented 3 years ago

Awesome! Thanks for your contribution 😃 I'm merging 👍

HelloThisIsFlo commented 3 years ago

And I've just released v4.0.0b2. It'll be up in a few minutes.