HelloWorld017 / atom-discord

Integrate with Discord and show Rich Presence information.
https://atom.io/packages/atom-discord
MIT License
106 stars 29 forks source link

custom image not support url #144

Closed ID29TH closed 1 year ago

ID29TH commented 1 year ago

Screenshot_2

Screenshot_3

I think custom image should support url because from my test it can put url , can you adjust and make it support ?

ShadowLp174 commented 1 year ago

Sadly, this doesn't work with Discords system... The image has to be an asset set in the (discord) app. The key you can enter here is just the name of the asset so discord knows which of your uploaded pictures to choose.

ShadowLp174 commented 1 year ago

The video you sent is quite interesting... Though it seems that image urls are some undocumented feature. The discord tool for rich presence does not allow non-asset inputs. I'll have a look at it when I get home

ShadowLp174 commented 1 year ago

Does it work in the atom package now?

ID29TH commented 1 year ago

I think it works Because I didn't customize anything, just use the image url, but your plugin, I'm not sure when choosing custom, how does package implement the value ?

ID29TH commented 1 year ago

Now package atom-discord doesn't work.

ID29TH commented 1 year ago

I don't know if the developer will try to fix or check ?

ShadowLp174 commented 1 year ago

Depending on the code of the package I'll try to implement it... It's still open source :)