HelloWorld017 / atom-discord

Integrate with Discord and show Rich Presence information.
https://atom.io/packages/atom-discord
MIT License
106 stars 29 forks source link

Add support for Pulsar Editor #150

Open mesub7 opened 6 months ago

mesub7 commented 6 months ago

As I'm sure you know, Atom was sunsetted a while back and a community-maintained replacement (Pulsar) has been available for a while. I don't suppose you could update the package to match this, please?

ShadowLp174 commented 6 months ago

Not the maintainer but I don't really expect any updates on here 🙃

Though, a few days ago, @siliconsniffer created a fork that's supposed to do what you're asking for (I'm not sure if it's completed already)

Link: https://github.com/siliconsniffer/pulsar-discord

Hope this helps, if you have any further questions just let me know

siliconsniffer commented 6 months ago

Not the maintainer but I don't really expect any updates on here 🙃

Though, a few days ago, @siliconsniffer created a fork that's supposed to do what you're asking for (I'm not sure if it's completed already)

Link: https://github.com/siliconsniffer/pulsar-discord

Hope this helps, if you have any further questions just let me know

Nope still WIP, not much progress done yet. If you want to, I can add you or @mesub7 to the repo. As far as I can see we need to change the details (e.g. Atom to Pulasr) in the json-files under /i18n. But I have no idea how the atom extensions work...

ShadowLp174 commented 6 months ago

Not the maintainer but I don't really expect any updates on here 🙃

Though, a few days ago, @siliconsniffer created a fork that's supposed to do what you're asking for (I'm not sure if it's completed already)

Link: https://github.com/siliconsniffer/pulsar-discord

Hope this helps, if you have any further questions just let me know

Nope still WIP, not much progress done yet. If you want to, I can add you or @mesub7 to the repo. As far as I can see we need to change the details (e.g. Atom to Pulasr) in the json-files under /i18n. But I have no idea how the atom extensions work...

Hmm I see I'm not sure if modifying the localisations will be enough, there may be hard coded values - we'll see ig

mzivic7 commented 1 month ago

Yes, you are correct, there is one almost hardcoded thing that needs to be changed: It is here. This is default value for Discord app ID. This app contains that "Playing Atom Editor" string and all images. Someone should create new app for Pulsar with updated images and "Playing Pulsar Edit". Creating custom app is explained in FAQ.

Also, to be sure every atom-discord string is replaced, here are commands for linux, run them in project directory:

find ./ -type f -exec sed -i 's/atom-discord/pulsar-discord/g' {} \;
find ./ -type f -exec sed -i 's/Atom-Discord/Pulsar-Discord/g' {} \;

It would be nice to see pulsar-discord on https://web.pulsar-edit.dev/