search

HelloWorld017 / atom-discord

Integrate with Discord and show Rich Presence information.
https://atom.io/packages/atom-discord
MIT License
105 stars 28 forks source link

energy impact ⚡️ #19

Closed marclundgren closed 6 years ago

marclundgren commented 6 years ago

I just spent about an hour diagnosing my Atom's high energy consumption and narrowed it down to this package. Discord was not open when I ran these tests.

I've got about 40 community packages combined. The total energy consumption saved when I disabled this package was about 2700% more efficient with atom-discord disabled.

:(

marclundgren commented 6 years ago

Looks like we're polling a remote endpoint on this line, which is likely the culprit for a high energy impact:

https://github.com/HelloWorld017/atom-discord/blob/master/src/send-discord.js#L87

marclundgren commented 6 years ago

A package configuration option for the poll interval (currently set to 3 seconds) is probably the easiest/quickest way to provide a solution that works for everyone.

TheOnlyArtz commented 6 years ago

Well, I won't target Atom-Discord but what I would do, Is opening an issue on Atom We all know that Atom is not that good when it comes to CPU usage and performance in general but somehow we will never stop love this JavaScript masterpiece

Anyways, being with 40 community packages which I can tell that most of them are doing some front-end stuff Will slowdown Atom nowhere near like backend work like Atom-Discord does. It isn't something new that backend is always slower than something that happens on your machine 😄 Hoped I've clarified some things

TheOnlyArtz commented 6 years ago

Oh the interval you're talking about shouldn't be like that and I can agree on that. I will make a pull request and see how it goes.

HelloWorld017 commented 6 years ago

Setting interval is already in settings (added at 4236d9a0914738d79f686f02dd267355b60b8159) You can find it Behaviour > Update Tick

TheOnlyArtz commented 6 years ago

That is still wrong @HelloWorld017 I'm making a PR right now to clarify things.

TheOnlyArtz commented 6 years ago

#20

HelloWorld017 commented 6 years ago

I really appreciate your contribution!

TheOnlyArtz commented 6 years ago

No problem, I'm just here to help some good ideas, glad that it is you to make it and not some guy who won't listen to his users

TheOnlyArtz commented 6 years ago

@marclundgren I hope #20 will make your PC to feel better 😄

TheOnlyArtz commented 6 years ago

@marclundgren @HelloWorld017 Can one of you close this issue please?