search

HelloWorld017 / atom-discord

Integrate with Discord and show Rich Presence information.
https://atom.io/packages/atom-discord
MIT License
105 stars 28 forks source link

Not Showing Correct Project for File being Edited #39

Closed Bioblaze closed 6 years ago

Bioblaze commented 6 years ago

Its not showing the actual project for the file currently being edited, only showing the first project int he tree-view. I fixed that with my git pull. #38

HelloWorld017 commented 6 years ago

Closed by #38

Ekidoxx commented 6 years ago

@Bioblaze & @HelloWorld017 Dunno whether I should write here or in the pull request, but once I have updated the package locally with content of this repository master-branch instead of checking it on package version 1.4.0, I found a bug.

Generally, the whole path-showing works great as I already wrote in other comment, but only until the editor starts with showing up any tab that isn't a file, like, for example, settings. Because then, the package partially fails to activate:

image image

There's the content of Stack Trace:

TypeError: Cannot read property 'buffer' of undefined
    at createLoop (C:\Users\Ekidoxx\.atom\packages\atom-discord\src\index.js:90:50)
    at Object.activate (C:\Users\Ekidoxx\.atom\packages\atom-discord\src\index.js:112:3)
    at Package.module.exports.Package.activateNow (C:\Users\Ekidoxx\AppData\Local\atom\app-1.23.1\resources\app\src\package.js:255:25)
    at C:\Users\Ekidoxx\AppData\Local\atom\app-1.23.1\resources\app\src\package.js:227:38
    at Package.module.exports.Package.measure (C:\Users\Ekidoxx\AppData\Local\atom\app-1.23.1\resources\app\src\package.js:99:21)
    at C:\Users\Ekidoxx\AppData\Local\atom\app-1.23.1\resources\app\src\package.js:220:32
    at Package.module.exports.Package.activate (C:\Users\Ekidoxx\AppData\Local\atom\app-1.23.1\resources\app\src\package.js:217:40)
    at PackageManager.activatePackage (C:\Users\Ekidoxx\AppData\Local\atom\app-1.23.1\resources\app\src\package-manager.js:695:42)
    at config.transactAsync (C:\Users\Ekidoxx\AppData\Local\atom\app-1.23.1\resources\app\src\package-manager.js:670:36)
    at Config.module.exports.Config.transactAsync (C:\Users\Ekidoxx\AppData\Local\atom\app-1.23.1\resources\app\src\config.js:367:24)
    at PackageManager.activatePackages (C:\Users\Ekidoxx\AppData\Local\atom\app-1.23.1\resources\app\src\package-manager.js:668:23)
    at PackageManager.activate (C:\Users\Ekidoxx\AppData\Local\atom\app-1.23.1\resources\app\src\package-manager.js:647:50)
    at C:\Users\Ekidoxx\AppData\Local\atom\app-1.23.1\resources\app\src\atom-environment.js:865:36

Would just like to mention - before anyone asks - that updating Atom didn't solve the issue, and that the bug doesn't happen with previous way of detecting projectName