HelloWorld017 / atom-discord

Integrate with Discord and show Rich Presence information.
https://atom.io/packages/atom-discord
MIT License
105 stars 28 forks source link

Says "Idle" if I turn off file names #40

Closed xdavidhu closed 6 years ago

xdavidhu commented 6 years ago

If I turn off the file name option, in the description atom-discord puts "Idle", but I am not idle.

I think putting the text with the file type e.g. "Editing a Python file." would be more logical and understandable for others if file names are turned off.

screen shot 2018-01-22 at 21 42 44

Btw awesome package, got super hyped when I saw it at someone else on a server :D

Ekidoxx commented 6 years ago

In my opinion there are two options, and I'd personally suggest implementing the second one

  1. Add new line under https://github.com/HelloWorld017/atom-discord/blob/29fabb2f121c145e1b6fae9870ec6420223a6012/i18n/en-US.json#L4 for editing file when showing file name is disabled, i.e.:

        "editing-some-file": "Editing some file",
  2. Change https://github.com/HelloWorld017/atom-discord/blob/29fabb2f121c145e1b6fae9870ec6420223a6012/src/send-discord.js#L130 to:

            }) : config.getTranslation('type-unknown');
HelloWorld017 commented 6 years ago

@xdavidhu Would you show your settings about privacy & behaviors? @Ekidoxx Unfortunately, 'editing-idle' of second one is the text which is shown when no files are opened. T_T

Ekidoxx commented 6 years ago

Since I get exactly same result:

image

Ekidoxx commented 6 years ago

Guess what @HelloWorld017, that also kind of got fixed once I manually updated package with content of this repo... But now it shows Editing a file even when there are no tabs open in Atom...

with active file: (good icon and title) with active settings: (good icon but wrong title) @
image image

image

HelloWorld017 commented 6 years ago

Because of slow update, you should wait for about 15s to update!

HelloWorld017 commented 6 years ago

I think this issue have been solved at a3dea3e3fb317e8044ea2cde5abf759fa16aa4a9. :D I'll upload to apm when testing #42 is finished.

xdavidhu commented 6 years ago

Just updated, it works really well! :D Thank you for the quick response & fix!

screen shot 2018-01-24 at 18 57 01