search

HelloWorld017 / atom-discord

Integrate with Discord and show Rich Presence information.
https://atom.io/packages/atom-discord
MIT License
105 stars 30 forks source link

Elapsed time does not reset when reopening Atom #66

Closed Davoleo closed 5 years ago

Davoleo commented 5 years ago

Step to reproduce

  1. Open Atom
  2. Close it
  3. Reopen it

Information

Platform: Windows 10 Atom: 1.31.1 Package Version: 1.6.1

Non-Core Packages

ZenScript 0.2.5
Teletype 0.13.3
HelloWorld017 commented 5 years ago

I found that some symptoms about it.

  1. When it occurs, it occurs to everyone in a server.
  2. Sometimes the time is normal for everyone.
  3. The time is fixed to some strange time (about 17h ~ 19h)
SHADOWELITE7 commented 5 years ago

apparently, when you are on mobile discord, it doesn't show any elapsed time, it's basically normal

ihulsbus commented 5 years ago

Same issue here.

Information

Platform: Mac OS 10.13.6 Atom: 1.31.2 Package Version: 1.6.1

Non-Core Packages

autocomplete-clang  0.11.5
build  0.70.0
busy-signal 1.4.3
city-lights-syntax 1.1.8
city-lights-ui  1.5.3
file-icons  2.1.25
intentions  1.1.5
jackhammer-syntax  1.1.0
language-ini  1.20.0
language-latex  1.2.0
latex  0.50.0
latex-completions  0.3.5
linter  2.2.0
linter-gcc  0.7.1
linter-ui-default  1.7.1
pdf-view  0.71.0
platformio-ide  2.2.2 (disabled)
platformio-ide-debugger  1.2.6 (disabled)
platformio-ide-terminal  2.8.4
tool-bar  1.1.10
Xpl0itR commented 5 years ago

I also have the same issue image

HelloWorld017 commented 5 years ago

Is anyone who has this problem after fbb66b9 ?

Xpl0itR commented 5 years ago

I installed it yesterday from the Atom package installer menu which im guessing is the latest version so yes it would be after fbb66b9.

HelloWorld017 commented 5 years ago

I didn't upload that commit to atom. So it must be before the commit.

Xpl0itR commented 5 years ago

Ahh i see, you gonna upload that commit to atom?

KlukCZ commented 5 years ago

I opened the source code in atom and changed it as its showed in fbb66b9 and its working

HelloWorld017 commented 5 years ago

Thx for testing! If there's no further bugs for more than some days, I'll upload it. (It's because the bug doesn't occur sometimes)

GorujoCY commented 5 years ago

@KlukCZ thanks for letting us know, it actually solves the problem

HelloWorld017 commented 5 years ago

Maybe related to discordjs/RPC 4fd073?

ihulsbus commented 5 years ago

Might be, but if I quickly look at it with fbb66b9 in mind it does not really make sense to me. Might be wrong though..

HelloWorld017 commented 5 years ago

That commit changed the type: from float-point to integer