search

HelloZeroNet / ZeroNet

ZeroNet - Decentralized websites using Bitcoin crypto and BitTorrent network
https://zeronet.io
Other
18.33k stars 2.27k forks source link

File browser thinks ogg files are editable. #2656

Closed styromaniac closed 3 years ago

styromaniac commented 3 years ago

Screenshot_20201020-162928

styromaniac commented 3 years ago

@styromaniac take a look at https://github.com/HelloZeroNet/ZeroNet/pull/2657/files#diff-7e8d4a72fd3f5dfb486ac0bd395fe33d2ba5d32336079c79bba4d7062650e9ee

Okay. I looked at it.

styromaniac commented 3 years ago

@styromaniac and? It works?

Oh. I didn't test it. Only my phone can connect to the internet right now, anyway, and I'm using ZeroNet Mobile.

purplesyringa commented 3 years ago

I'm pretty sure it works.

Of course it does not. You're looking for this line:

https://github.com/HelloZeroNet/ZeroNet/blob/29dac8a1889e6c23773292718bec813e00ae2d74/plugins/UiFileManager/media/js/FileList.coffee#L1

I believe it should be a text file whitelist instead of blacklist though. Perhaps whitelisting txt, json, html, css, js and a few others I can't remember now should work.

purplesyringa commented 3 years ago

The applications logo is based on the logo of the Electrum bitcoin wallet, I strongly recommend to remove the ZeroNet Mobile if you have Electrum installed and you have bitcoin in that wallet.

Now that is an interesting way to find malicious packages. Oh, its icon is similar to Electrum, oh fuck, remove it ASAP!

styromaniac commented 3 years ago

I'm pretty sure it works.

@imachug the android application has an "Offers in-app purchases" on Google Play which is a bad sign. @styromaniac I'm not recommending using the android application.

The applications logo is based on the logo of the Electrum bitcoin wallet, I strongly recommend to remove the ZeroNet Mobile if you have Electrum installed and you have bitcoin in that wallet.

I don't have any BTC.

purplesyringa commented 3 years ago

ZeroNet is basically a JavaScript software full of shitty coffee scripts

How would you make a web application without JavaScript?

purplesyringa commented 3 years ago

In the other hand the application on Google Play has permissions like BILLING which along with Electrum and ZeroNet running can result in stolen funds. Why need ZeroNet Mobile BILLING permission? I tell you, because it is a scam!

Then report it to the correct repository, nofish has no connection with the ZeroNet-kivy project.

purplesyringa commented 3 years ago

Tell me @imachug why the plugin need a different list of mime types when UiRequest already has them

That is a good question. Perhaps it'd be a good idea to use server-side mimetype module to detect file types without additional detection by browser. @HelloZeroNet Agreed?

purplesyringa commented 3 years ago

This does not imply that Python is being replaced, it just means more JS code is added. I don't see how this is a problem.

purplesyringa commented 3 years ago

:roll_eyes:

HelloZeroNet commented 3 years ago

It should be fixed by https://github.com/HelloZeroNet/ZeroNet/commit/4f6833c488258d4a34242a3c589da89b8c0ba417 in Rev4539