search

HelloZeroNet / ZeroTalk

ZeroTalk
GNU General Public License v2.0
60 stars 47 forks source link

Use date of vote instead of a 'one' #90

Closed purplesyringa closed 5 years ago

purplesyringa commented 5 years ago

Hello. Currently, topic URIs, comment URIs and basically everything else on most default sites contain date. However, I've just noticed that a plain "1" digit is used for votes, like this:

  ...
  "8_12zcNM3BD6QwkonPrnCdbWBnGzu9b1rQRA": 1,
  ...

That doesn't sound like a good idea to me. One of the reasons is that using "1" makes mirroring ZeroTalk threads to other services more difficult: namely, it's not enough to just check a part of upvotes posted after a specific time. This is troublesome in messengers like Matrix: it allows getting n latest events (i.e. messages/upvotes/etc.), so without this PR merged, I'd have to load all events just to find what upvotes were counted and what weren't. On the other side, this PR won't affect UI/UX but will make mirroring easier.

blurHY commented 5 years ago

@shortcutme @HelloZeroNet

purplesyringa commented 5 years ago

@HelloZeroNet What do you think about this?

purplesyringa commented 5 years ago

@HelloZeroNet This PR blocks release of my project. Can you please merge it?

blurHY commented 5 years ago

As you see, huh.

He didn't even reply or merge this simple PR.

purplesyringa commented 5 years ago

Yay, thanks!