Hellohi3654 / Geyser

A Modified bridge/proxy allowing you to connect to Minecraft: Java Edition servers with Minecraft: Bedrock edition.
https://infinite.sbs
MIT License
7 stars 2 forks source link

server-inventory? #261

Closed zimzaza4 closed 3 years ago

zimzaza4 commented 3 years ago

What feature do you want? Add a description Can you merge this branch? https://github.com/Camotoy/Geyser/tree/server-inventory

This fixes many inventories

Hellohi3654 commented 3 years ago

Ok I will have a look

Hellohi3654 commented 3 years ago

The release I'm about to release will not include the server-inventory branch but the next one after it will include the server-inventory branch

Hellohi3654 commented 3 years ago

I have created a test branch for the server-inventory branch You can download artifacts here https://github.com/Hellohi3654/Geyser/actions/runs/455242409

zimzaza4 commented 3 years ago

If you take items from the creative mode inventory, the player will be forced to disconnect

zimzaza4 commented 3 years ago

Ummm...seems to be disconnected after moving an item

Hellohi3654 commented 3 years ago

yeah there's a few bugs that's why I made a test branch

Hellohi3654 commented 3 years ago

Here's another build Might fix some issues https://github.com/Hellohi3654/Geyser/actions/runs/455578047

Hellohi3654 commented 3 years ago

Sorry this one if it doesn't fail https://github.com/Hellohi3654/Geyser/actions/runs/455584212

Hellohi3654 commented 3 years ago

No sorry again this one should be it https://github.com/Hellohi3654/Geyser/actions/runs/455586366

Hellohi3654 commented 3 years ago

This one https://github.com/Hellohi3654/Geyser/actions/runs/455586366

zimzaza4 commented 3 years ago

Still the same problem...

zimzaza4 commented 3 years ago

https://ci.opencollab.dev/job/GeyserMC/job/Geyser/job/server-inventory/ They don’t seem to build successfully...

zimzaza4 commented 3 years ago

Players will be disconnected because of CLOSED_BY_REMOTE_PEER

Hellohi3654 commented 3 years ago

Yeah not sure why I think it's because of some case: Also not sure why players are disconnected

Here I fixed the problem causing: https://ci.opencollab.dev/job/GeyserMC/job/Geyser/job/server-inventory/ not to build

https://github.com/Hellohi3654/Geyser/actions/runs/455616906

zimzaza4 commented 3 years ago

2021-01-01 12:22:01.406 [Network Listener - #5] I - ItemStackRequestPacket(requests=[ItemStackRequestPacket.Request(requestId=-3, actions=[DestroyStackRequestActionData(count=1, source=StackRequestSlotInfoData(container=HOTBAR, slot=7, stackNetworkId=34))])])

The information output before the player disconnects

zimzaza4 commented 3 years ago

Yeah not sure why I think it's because of some case: Also not sure why players are disconnected

Here I fixed the problem causing: https://ci.opencollab.dev/job/GeyserMC/job/Geyser/job/server-inventory/ not to build

https://github.com/Hellohi3654/Geyser/actions/runs/455616906

Wait, I'll try it first

Hellohi3654 commented 3 years ago

ok

Hellohi3654 commented 3 years ago

2021-01-01 12:22:01.406 [Network Listener - #5] I - �[0m�[1mItemStackRequestPacket(requests=[ItemStackRequestPacket.Request(requestId=-3, actions=[DestroyStackRequestActionData(count=1, source=StackRequestSlotInfoData(container=HOTBAR, slot=7, stackNetworkId=34))])])�

The information output before the player disconnects

Honestly not sure how to fix that

zimzaza4 commented 3 years ago

Cannot take items from the creative inventory

zimzaza4 commented 3 years ago

But those stocks seem to be available

zimzaza4 commented 3 years ago

There are some minor issues

Hellohi3654 commented 3 years ago

yeah smithing tables stonecutters and stuff still don't work

zimzaza4 commented 3 years ago

I think they will spend a long time on that branch..

Hellohi3654 commented 3 years ago

Yeah most likely

Hellohi3654 commented 3 years ago

Here are another two builds Hellohi3654 version: https://github.com/Hellohi3654/Geyser/actions/runs/456904619

GeyserMC official: https://github.com/Hellohi3654/Geyser/actions/runs/456904940

zimzaza4 commented 3 years ago

Is it merged https://github.com/GeyserMC/Geyser/tree/server-inventory?

Hellohi3654 commented 3 years ago

yeah

Hellohi3654 commented 3 years ago

not into bundabrg-bleeding

Hellohi3654 commented 3 years ago

there are still alot of issues

Hellohi3654 commented 3 years ago

Here's another update to my version: https://github.com/Hellohi3654/Geyser/actions/runs/456983495

Hellohi3654 commented 3 years ago

Update to my version again Crafting tables should work: https://github.com/Hellohi3654/Geyser/actions/runs/457384913

DUDEbehindDUDE commented 3 years ago

crafting works client-side but not server side

zimzaza4 commented 3 years ago

They updated this branch at https://github.com/Camotoy/Geyser/tree/server-inventory

Hellohi3654 commented 3 years ago

ok I'll update my branch

Hellohi3654 commented 3 years ago

Update: https://github.com/Hellohi3654/Geyser/actions/runs/474965543

Hellohi3654 commented 3 years ago

nevermind seems to crash on startup

Hellohi3654 commented 3 years ago

https://github.com/Hellohi3654/Geyser/actions/runs/474982674

Hellohi3654 commented 3 years ago

?

zimzaza4 commented 3 years ago

Well, it seems to be a small chance problem

Hellohi3654 commented 3 years ago

weird

Hellohi3654 commented 3 years ago

hang on I'm compiling another build

zimzaza4 commented 3 years ago

Player inventory is still problematic...

Hellohi3654 commented 3 years ago

https://github.com/Hellohi3654/Geyser/actions/runs/475005374

Hellohi3654 commented 3 years ago

yeah

Hellohi3654 commented 3 years ago

try that one ^

zimzaza4 commented 3 years ago

IMG20210110112753 I dropped the item

zimzaza4 commented 3 years ago

But the items in the inventory have not changed IMG20210110112806

Hellohi3654 commented 3 years ago

I don't think they've added that yet

zimzaza4 commented 3 years ago

https://github.com/Hellohi3654/Geyser/actions/runs/475005374

Ok i'll try

Hellohi3654 commented 3 years ago

once it's done