Hellomon / rerouter

1 stars 1 forks source link

NPM Registry? #25

Open mcs opened 9 months ago

mcs commented 9 months ago

Hi,

I'm still relatively new to this project and its eco system, but wouldn't it make sense if the latest Rerouter was in the NPM registry?

The example at https://github.com/r2-studio/robotmon-scripts/tree/master/scripts/com.r2studio.TsumRerouter is broken because it references a non-existing Rerouter folder. And https://github.com/r2-studio/robotmon-scripts/tree/master/scripts/com.r2studio.MLB9Innings sources all destination files (?) into index.js which doesn't look quite preferable to me.

What is the actual preferred way to get the built files into another project?

All the best, Marcus

Sean-Hsueh commented 2 weeks ago

Hi mcs,

Sorry for not responding sooner. I think you are confused because these two scripts are actually written in .ts. What you see here is compiled version so these .js is quite not human readible.

In our typescript source code, the way I do it is to lock the rerouter version like below in packages.json:

"dependencies": { "Rerouter": "git://github.com/Hellomon/rerouter.git#f7140c0d456396a444702085bd07151e8e4f0e60" },