search

Hellowlol / HTPC-Manager

A fully responsive interface to manage all your favorite software on your Htpc.
MIT License
345 stars 48 forks source link

rtorrent module #490

Closed mattberther closed 8 years ago

mattberther commented 8 years ago

Very early on -- but I wanted to open the pull request to 1) see if there was interest in this, and 2) identify with the community what features should be added.

At this time, my fork only shows the torrent lists. Key things Id like to get added:

What else?

BTW: most of the UI code was shamelessly "borrowed" from the deluge presentation. :)

Hellowlol commented 8 years ago

Thanks for the pr. I'm sure some guys would be happy to get support for rtorrent.

While your at it you can add it to the torrent search module. See https://github.com/Hellowlol/HTPC-Manager/blob/master2/modules/torrentsearch.py#L173 for a example

It also needs to support uploading a link or magnet to rtorrent for the torrent module to work. Or write a wrapper that handles that.

Hellowlol commented 8 years ago

@mattberther Is this pr done?

mattberther commented 8 years ago

No - sorry. Im still working on it - but had some stuff come up that took time away from this. Im expecting to get back to it this weekend.

mattberther commented 8 years ago

@Hellowlol I believe this is complete - only thing Im waiting on is an icon from rg-icons. There's an open issue logged there: https://github.com/raysguy/rg-icons/issues/2

Want to make a final review and let me know if you have any changes?

Hellowlol commented 8 years ago

Thanks. Ill review it later today.

Hellowlol commented 8 years ago

I havnt tested it but it looks fine.

I just have some comments regarding style.

remove unneeded ; to terminate a line intent is 4 spaces remove whitespace inside a () {} etc remove unneed (), its not needed for conditions statements in python

mattberther commented 8 years ago

@Hellowlol ill update the indents...

Just to be clear: the following comments are related to the js file, yes? With the second comment, Im also assuming that you want no whitespace inside any methods. Correct?

remove unneeded ; to terminate a line remove whitespace inside a () {} etc

Im not following what you're asking for with this comment -- can you provide an example of what needs to be updated and Ill fix?

remove unneed (), its not needed for conditions statements in python

Thanks!

Hellowlol commented 8 years ago

No i was referring the .py file. The js file looked fine.

mattberther commented 8 years ago

Thanks! I think I got em now. :)