search

Hellowlol / HTPC-Manager

A fully responsive interface to manage all your favorite software on your Htpc.
MIT License
344 stars 48 forks source link

Feature Request: Display more stream information in PlexPy #577

Closed Kazz3r24 closed 6 years ago

Kazz3r24 commented 6 years ago

Reporting Issues:

To ensure that a I has enough information to work with please include all of the following information.

Use proper markdown syntax to structure your post (i.e. code/log in code blocks).

Make sure you provide the following information below:

Close your issue when it's solved! If you found the solution yourself please comment so that others benefit from it. capture

Link to log: https://imgur.com/Z9Ca9v1

jeremysherriff commented 6 years ago

I'll have a hack at this. Fair warning: my coding is pretty poor, I'm an infrastructure engineer :)

jeremysherriff commented 6 years ago

How's this look: image

Kazz3r24 commented 6 years ago

That looks perfect, exactly what I was looking for!

jeremysherriff commented 6 years ago

Sweet. Just cleaning up a couple of bits and I'll send a pull request to Hellowlol

On 1 April 2018 at 13:07, Kazz3r24 notifications@github.com wrote:

That looks perfect, exactly what I was looking for!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Hellowlol/HTPC-Manager/issues/577#issuecomment-377734917, or mute the thread https://github.com/notifications/unsubscribe-auth/ABCDZVNCssoTp6cnLFggp_WmMjnHx7SHks5tkChGgaJpZM4SaIX8 .

jeremysherriff commented 6 years ago

Just realised I didn't include the subtitles line. I've already submitted the pull request. But looking at the layout there isn't actually space for the subtitles info..

I'm reasonably confident there'll be at least one bug so assuming that I'll be doing an edit on this soon, I'll collapse the top two lines together and add subtitle info then.

jeremysherriff commented 6 years ago

Just submitted a PR with a few bugfixes. @Kazz3r24 can you close this issue if you're happy with it?

jeremysherriff commented 6 years ago

image image

Kazz3r24 commented 6 years ago

It looks pretty much perfect! Exactly what I was looking for. My only issue I'm having, and I'm not sure if it's on my end or where.

image

The progress bar for media seems to be getting cut off due to large images. So I don't know if it's something I can tweak, or where those settings are.

I did already try clearing my browser cache to see if that would fix it, still nothing so far. I also just restarted the service, issue remains.

Kazz3r24 commented 6 years ago

Once I get that fixed, I'll be 1000% satisfied and will certainly close the issue. Thanks again for all of your hard work! I'll need to brush up on my various coding languages so I can help out!

jeremysherriff commented 6 years ago

Wow, that's not looking right. What resolution is your monitor at? Can you try taking your browser down to a window instead of full screen, and making it narrower? Does that seem to resize the bars and images?

I noticed when editing the code that some of the sizing is in "%" and some of it is in pixels. I'm guessing you have a screen size that is quite different to any of mine (I think mine are all 1920x1080) and some of the % width stuff is causing the image to stretch taller to compensate for the increased width.

I'll try replicate it but if you could let me know about your screen resolution & whether changing the browser window size helps, that would be great.

jeremysherriff commented 6 years ago

PS does it look OK with just one stream playing?

Kazz3r24 commented 6 years ago

I will have to try it out and see how things look with one stream. My monitor and resolution are 1920x1080 as well. Thanks for looking into this!

jeremysherriff commented 6 years ago

@Kazz3r24 fyi I've been able to reproduce your situation. Seems it's totally different in Edge, IE, Chrome and Firefox. Different browser window sizes definitely contribute to it.

...fml..

Kazz3r24 commented 6 years ago

LOL I'm sorry this has turned into a bit of a nightmare. I was able to get everything looking normal by shrinking my browser window down. Even with one stream going at full screen the issue remains. If there's anything I can do to help I am more than willing and capable.

Thanks for your efforts again!

jeremysherriff commented 6 years ago

OK fixed it. Stupid MS Edge is stupid, and I had to rewrite the whole thing to cater for one browser dong tables differently. :)

Kazz3r24 commented 6 years ago

LOL I could have told your Edge is stupid :P, that's silly... should be standards for that. Either way, I'm going to close this ticket. I believe you've more than exceeded what I asked for and I'll know for sure once the pull request goes through and I update. Thank you again for all of your efforts! It's so nice having just one tab open!

jeremysherriff commented 6 years ago

@Kazz3r24 just fyi the fixes have been merged in, so check for updates.

Kazz3r24 commented 6 years ago

Perfect! Sure thing, I'll update as soon as I get a chance and get back to you. Thanks again!

Kazz3r24 commented 6 years ago

Looks absolutely perfect now! Thank you guys so much for your efforts!