Hellowlol / bw_plex

binge watching for plex
MIT License
368 stars 23 forks source link

Improve Dockerfile #57

Closed sammcj closed 5 years ago

sammcj commented 5 years ago

It's still based on Ubuntu, which is not something I recommend for Dockerfiles (or a distribution for that matter but that's another discussion) - however most of the weight is coming from the libLLVM requirement (which I'm guessing is still required after install?), so if that's required, it's still going to be large:

--- /usr/lib 
-----------------------------------------------
                         /..
  333.8 MiB [##########] /x86_64-linux-gnu
   94.2 MiB [##        ] /python3.6
   84.8 MiB [##        ] /gcc
   21.7 MiB [          ] /git-core
   13.5 MiB [          ] /python3
--- /usr/lib/x86_64-linux-gnu
-----------------------------------------------
                         /..
   58.3 MiB [##########]  libLLVM-6.0.so.1
   32.7 MiB [#####     ] /dri
   25.7 MiB [####      ]  libicudata.so.60.2
   19.6 MiB [###       ] /perl
   13.1 MiB [##        ]  libavcodec.so.57.107.100
   10.4 MiB [#         ]  libx265.so.146

Note that python's libpython3.6m is also relatively large, I'm not a python dev so I'm unsure of it's requirements, if it's not required after install, perhaps it could be purged after the pip install phase, but I'm guess it is required:

--- /usr/lib/python3.6/config-3.6m-x86_64-linux-gnu
-----------------------------------------------
                         /..
   36.2 MiB [##########]  libpython3.6m.a
   35.5 MiB [######### ]  libpython3.6m-pic.a
   84.0 KiB [          ]  python.o

Note: this still has one linter warning 'Consider using a --no-install-recommends when apt-get installing packages' but that does seem to break the build and I didn't spend further time to figure out which recommended package is actually required.

codecov[bot] commented 5 years ago

Codecov Report

Merging #57 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #57   +/-   ##
=======================================
  Coverage   77.16%   77.16%           
=======================================
  Files           8        8           
  Lines        1187     1187           
=======================================
  Hits          916      916           
  Misses        271      271

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6bbad4e...3040552. Read the comment docs.

Hellowlol commented 5 years ago

Thanks alot. Im really out of my depth regarding dockers :)

sammcj commented 5 years ago

No problems, obviously because packages aren’t pinned to versions YMMV over time but that’s already the case.