Closed sammcj closed 5 years ago
Merging #57 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #57 +/- ##
=======================================
Coverage 77.16% 77.16%
=======================================
Files 8 8
Lines 1187 1187
=======================================
Hits 916 916
Misses 271 271
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6bbad4e...3040552. Read the comment docs.
Thanks alot. Im really out of my depth regarding dockers :)
No problems, obviously because packages aren’t pinned to versions YMMV over time but that’s already the case.
It's still based on Ubuntu, which is not something I recommend for Dockerfiles (or a distribution for that matter but that's another discussion) - however most of the weight is coming from the libLLVM requirement (which I'm guessing is still required after install?), so if that's required, it's still going to be large:
Note that python's libpython3.6m is also relatively large, I'm not a python dev so I'm unsure of it's requirements, if it's not required after install, perhaps it could be purged after the pip install phase, but I'm guess it is required:
Note: this still has one linter warning 'Consider using a
--no-install-recommends
whenapt-get
installing packages' but that does seem to break the build and I didn't spend further time to figure out which recommended package is actually required.