config.yaml wrong for Universal models

HelmchenLabSoftware / Cascade

Calibrated inference of spiking from calcium ΔF/F data using deep networks

GNU General Public License v3.0

123 stars 34 forks source link

config.yaml wrong for Universal models #10

Closed Vanwalleghem closed 4 years ago

Vanwalleghem commented 4 years ago

Hey,

it seems there's a typo in all the config.yaml files for the Universal models, it says they've been trained on (line 13)

-DS07-GCaMP6f-zf-dD

but the provided ground truth is

DS07-GCaMP6f-zf-OB

which one is right?

PTRRupprecht commented 4 years ago

Hi Gilles,

Well spotted! When I trained the Universal models, by accident the filename was wrong ('DS07-GCaMP6f-zf-dD'), such that the automatically generated config.yaml file propagated this error. After that, I simply renamed the folder to the correct name ('DS07-GCaMP6f-zf-OB').

I'll check how this typo can be correct for all the dozen of Universal models.

PTRRupprecht commented 4 years ago

Is fixed now.