HeloiseS / hoki

Bridging the gap between observation and theory
https://heloises.github.io/hoki/intro.html
BSD 3-Clause "New" or "Revised" License
47 stars 8 forks source link

[BUG] BPASS Resolution is fixed to FWHM=1A in make_templates #104

Open Knusper opened 4 months ago

Knusper commented 4 months ago

Reading the code, I see that you fix FWHM=1A for the BPASS SEDs when preparing them for ppxF.
This is the sampling of the models, not the resolution. My understanding is thus, that fwhm_tmp shuold be 0.

On a related note: In the tutorial I see that you use 1.25 A as the FWHM of the resolution for MUSE. This is also not correct - this is the standard sampling from the pipeline. The MUSE LSF FWHM is wavelength dependent, and approximately twice that value (see e.g. Eq. 1 in Bacon et. al. 2023).

This could potentially affect kinematic analyses.