HeloiseS / hoki

Bridging the gap between observation and theory
https://heloises.github.io/hoki/intro.html
BSD 3-Clause "New" or "Revised" License
47 stars 8 forks source link

default BPASS version is 221. Can't use filters from 222 #21

Closed glebgeinke closed 4 years ago

glebgeinke commented 4 years ago

HokiKeyError: One or both of the chosen filters do not correspond to a valid filter key. from cmd.py

Try/except checks filters against columns in self.dummy_dict[key], where

Just changing that to v222 helps

glebgeinke commented 4 years ago

Here is the file I ran that was giving the error

GAIA_M67.zip

HeloiseS commented 4 years ago

did you change the bpass_version to 'v222' when you call the object? you really need to do that if you want to be able to use bpass v2.2.2. You can also cahnge your default bpass version if you want

glebgeinke commented 4 years ago

Ohhh I only just realise that I could've just added it in the argument, my bad! Yes, I just changed the default. Thank you though, that was a but dumb of me xD

On Fri, May 22, 2020, 1:26 PM Heloise notifications@github.com wrote:

did you change the bpass_version to 'v222' when you call the object? you really need to do that if you want to be able to use bpass v2.2.2. You can also cahnge your default bpass version if you want

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/HeloiseS/hoki/issues/21#issuecomment-632427777, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOWJUCDBEK2FZHDQAAODA7TRSXIDTANCNFSM4NF2C3WQ .

HeloiseS commented 4 years ago

ain't nothing dumb about learning ;)