search

HeloiseS / hoki

Bridging the gap between observation and theory
https://heloises.github.io/hoki/intro.html
BSD 3-Clause "New" or "Revised" License
47 stars 8 forks source link

Utils for binning of spectra. #52

Closed findesgh closed 3 years ago

findesgh commented 4 years ago

Re-implementation of the binning utilities of pyBASS using numba. I haven't quite managed to achieve the same performance as that of the original Fortran implementation, but this should not be a problem even if binning millions of spectra.

findesgh commented 3 years ago

No worries, thanks for taking a look!

Regarding the location in utils: I used csp as a base branch for this since I need the spectra loading functionality for #46. And the spec module has not yet been merged into csp. In principle, though, feel free to move the code to where you see fit :-).

Will address the other issues as time permits.

findesgh commented 3 years ago

Merged dev1.6 into this and chose it as base branch as well, as that makes more sense, I suppose. Should I move the functionality to hoki/spec.py?

HeloiseS commented 3 years ago

Merged dev1.6 into this and chose it as base branch as well, as that makes more sense, I suppose. Should I move the functionality to hoki/spec.py?

great, that makes sense :)