BUG: use np instead of pd in SpectraCompiler.

HeloiseS / hoki

Bridging the gap between observation and theory

https://heloises.github.io/hoki/intro.html

BSD 3-Clause "New" or "Revised" License

47 stars 8 forks source link

BUG: use np instead of pd in SpectraCompiler. #60

Closed findesgh closed 4 years ago

findesgh commented 4 years ago

This is an alternative to #59, either fixes not being able to load for me. This one uses numpy exclusively pandas.

maxbriel commented 4 years ago

Hi findesgh,

Thank you for the different implementation! The SpectraCompiler issue is solved using the pandas method at the moment. Did you already have a look at the performance this method vs the pandas one?

Since the tests for the SpectraCompiler are a little tricky, I will have a look at them to make them work for this method.

findesgh commented 4 years ago

Yes, I noticed that a few other tests are failing as well. Now I hope that they should pass.

I haven't compared the performance, no. I just think using numpy is a bit easier in this case. Just a suggestion, though.