Closed findesgh closed 4 years ago
@maxbriel could you please check if the changes proposed here are ok for you? I think they only affect code you "own".
Hi Martin,
Thank you for your contribution! Love the abstraction and inheritance! Currently, I am rather busy, but will check the proposed changes fully before the end of next week! Thank you for your patience!
Hi Martin,
I finally got around to inspecting the changes. Thank you for also cleaning up some of the doc strings! To keep consistency, we're merging csp
into our dev1.6
branch first and then adding this addition to the dev1.6 branch.
For this I have merged dev1.6
into the data_loading
.
I have also made the following changes:
all_emissivity
to emissivity_all_z
r for consistency data_compiler
to a if/else statement that checks for the existence of the compiled file.BPASS_METALLICITIES
When the tests pass, it will be merged into dev1.6
.
This is a pre-requisite for the completion of #46. It does for the emissivities what is already there for the spectra in terms of compilation to
npy
files and loading.