search

HelpChat / ChatChat

ChatChat - Coming Soon
MIT License
51 stars 33 forks source link

ChatChat doesn't send message when player lacks perms to see default channels #160

Closed Andre601 closed 1 year ago

Andre601 commented 2 years ago

When you don't explicitly grant chatchat.channel.see.<default_channel_name> for the normal player to see the default channel is ChatChat treating it as if the player isn't allowed to see it, resulting in their messages not being displayed in chat, but still logged in console.

ChatChat should actually treat no see permissions as using the default channel without any permission checks.

BlitzOffline commented 2 years ago

I am pretty sure I've actually fixed this in a PR. I Just don't remember which. I will be testing again this week just to make sure.

EDIT: The PR that should've fixed this was #106

BlitzOffline commented 1 year ago

Closed. Retested just to make sure and it seems to be fixed.