HelpChat / DeluxeMenus

DeluxeMenus but open source!?
https://wiki.helpch.at/clips-plugins/deluxemenus
MIT License
72 stars 35 forks source link

Disable placeholders inside arguments by default + itemhook palceholder support fix #46

Closed BlitzOffline closed 6 months ago

BlitzOffline commented 7 months ago
BlitzOffline commented 7 months ago

Tested the following scenario: image

with option enabled: image

with option disabled: image

BlitzOffline commented 7 months ago

Found possible issue with last change: if action is executed with delay, holder could not be valid anymore which is why it shouldn't actually be passed to ClickActionTask. This might be a bigger issue with delays that needs investigation

UPDATE: It seems that arguments were set on task initialization and not task execution because they are not available at execution. Placeholders however need to be set at execution time to make sure they return the most up to date value. I think the best solution that would sync actions with everything else is to provide arguments at execution time.

BlitzOffline commented 7 months ago

Fixed issues and retested!