Closed BlitzOffline closed 6 months ago
Tested the following scenario:
with option enabled:
with option disabled:
Found possible issue with last change: if action is executed with delay, holder could not be valid anymore which is why it shouldn't actually be passed to ClickActionTask. This might be a bigger issue with delays that needs investigation
UPDATE: It seems that arguments were set on task initialization and not task execution because they are not available at execution. Placeholders however need to be set at execution time to make sure they return the most up to date value. I think the best solution that would sync actions with everything else is to provide arguments at execution time.
Fixed issues and retested!
Added per menu option
arguments_support_placeholders
that takes in a boolean value and defaults tofalse
. When option isfalse
, placeholders are not parsed inside user arguments.Changed how placeholders and arguments are parsed: arguments first (with placeholders inside value parsed if option mentioned above is true) and then placeholders
Fixed placeholders not being parsed for itemhooks anymore.