search

HelpChat / DeluxeMenus

DeluxeMenus but open source!?
https://wiki.helpch.at/clips-plugins/deluxemenus
MIT License
72 stars 35 forks source link

Wrong material display #51

Closed kristophergeou closed 7 months ago

kristophergeou commented 7 months ago

These following material options return STONE instead of AIR as a display for the item, when the slot is empty. armor_helmet, armor_chestplate, armor_leggings, armor_boots

Example Menu:

menu_title: '&8Stone'
size: 9
items:
  'armor_helmet':
    material: armor_helmet
    slot: 0
  'armor_chestplate':
    material: armor_chestplate
    slot: 1
  'armor_leggings':
    material: armor_leggings
    slot: 2
  'armor_boots':
    material: armor_boots
    slot: 3
iGabyTM commented 7 months ago

This just needs to be changed to return AIR, and also add a material check for AIR https://github.com/HelpChat/DeluxeMenus/blob/bf210e64bbd766e1ab363d212e84f00db7ad3520/src/main/java/com/extendedclip/deluxemenus/menu/MenuItem.java#L67-L69

kristophergeou commented 7 months ago

:O thats easy, i can do that!