Closed LoJoSho closed 6 months ago
I love the idea but I feel like it is a bit limited. Why have 1 option for appending lore at the bottom of the current lore when you can have an option that lets you: override lore, append at the bottom, append at the top, ignore. example:
lore-append-mode: 'override'
lore-append-mode: 'bottom'
lore-append-mode: 'top'
lore-append-mode: 'ignore'
If the option is missing, default to override
which is what currently happens.
I love the idea but I feel like it is a bit limited. Why have 1 option for appending lore at the bottom of the current lore when you can have an option that lets you: override lore, append at the bottom, append at the top, ignore. example:
lore-append-mode: 'override' lore-append-mode: 'bottom' lore-append-mode: 'top' lore-append-mode: 'ignore'
If the option is missing, default to
override
which is what currently happens.
Updated the PR with the requested changes :)
Is ignore_lore
still needed if lore_append_mode: 'ignore'
exists?
Is
ignore_lore
still needed iflore_append_mode: 'ignore'
exists?
Lore append mode ignore is in case a user wants to just add the lore of the hooked item and not the lore of the DeluxeMenu lore (kinda raises the point of, well, if they don't want lore why didn't they just remove the lore in DMs config), but it's an option nonetheless in case users just wish to kind their DM item lore and just have the hooked item lore.
Removed ignore lore option, lore: []
now works as suggested.
Any updates on this?
This adds the
lore_append_mode
option to items, allowing users better control over their lore. This is especially useful for servers using hooks with other plugins, as occasionally you want the items lore from those plugins but in different areas on the item in DM. An example that we ran into was our shop, were we wanted the Oraxen lore to make it easy to update DM when we change items in Oraxen. There are 4 options:IGNORE: This makes it so that it only takes the hooked items lore TOP: This adds the DM lore on top BOTTOM: This adds the DM lore on the bottom OVERRIDE: Default behavior right now, DM lore overrides hooked item lore.
Before:![javaw_maDFeUke5c](https://github.com/HelpChat/DeluxeMenus/assets/37521985/bdfb9698-384f-4dd5-9410-84c88e503660)
After:![javaw_oyqoHkB4Tx](https://github.com/HelpChat/DeluxeMenus/assets/37521985/721ae3cd-d65b-46b9-9153-bde8390d445d)
Example:
Feedback is welcome and encouraged!