HelpChat / DeluxeMenus

DeluxeMenus but open source!?
https://wiki.helpch.at/clips-plugins/deluxemenus
MIT License
61 stars 31 forks source link

Added support for armor trims #79

Closed BlitzOffline closed 2 months ago

BlitzOffline commented 3 months ago

This PR adds support for ArmorTrims and Closes https://github.com/HelpChat/DeluxeMenus/issues/55.

To use this new feature, 2 new options were added: trim_material and trim_pattern. These options can be set for each item in each menu but will only work for armor items. Both of these options support placeholders and arguments. The options are also case-sensitive.

This change was tested on:

BlitzOffline commented 3 months ago

I have talked with @Starmism and it seems it might be better to use TrimPattern#match instead of TrimPattern#get. This is to allow custom trim patterns with custom namespaces to be used. If no : is found in the string, minecraft: namespace could be appended as a prefix.