search

HelpChat / DeluxeMenus

DeluxeMenus but open source!?
https://wiki.helpch.at/clips-plugins/deluxemenus
MIT License
78 stars 37 forks source link

placeholder action return empty #86

Closed FakEEE14 closed 2 months ago

FakEEE14 commented 6 months ago

hi when you use [placeholder] action and if it's empty it's retrun it's empty

action:

  - '[placeholder] %luckperms_meta_randomstuff%'

error:

[DeluxeMenus] Task #537 for DeluxeMenus v1.14.1-DEV-178 generated an exception java.lang.NullPointerException: Cannot invoke "com.extendedclip.deluxemenus.menu.MenuHolder.setPlaceholders(String)" because "holder" is null at com.extendedclip.deluxemenus.action.ClickActionTask.run(ClickActionTask.java:87) ~[DeluxeMenus-1.14.1-DEV-178 (1).jar:?] at org.bukkit.craftbukkit.v1_20_R1.scheduler.CraftTask.run(CraftTask.java:101) ~[paper-1.20.1.jar:git-Paper-95] at org.bukkit.craftbukkit.v1_20_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:480) ~[paper-1.20.1.jar:git-Paper-95] at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1480) ~[paper-1.20.1.jar:git-Paper-95] at net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:447) ~[paper-1.20.1.jar:git-Paper-95] at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1394) ~[paper-1.20.1.jar:git-Paper-95] at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1171) ~[paper-1.20.1.jar:git-Paper-95] at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:318) ~[paper-1.20.1.jar:git-Paper-95] at java.lang.Thread.run(Thread.java:833) ~[?:?]

BlitzOffline commented 5 months ago

I am not sure if this is related to the action itself. It seems to me that the error you sent is incomplete. Can you send either full server logs or just check a few lines above the exception sent by you for other exceptions?

FakEEE14 commented 5 months ago

it's just this error, i open a menu that have open_commands placeholder and it's pop this error

BlitzOffline commented 4 months ago

Hello @FakEEE14 . It has been a while. Sorry about that. I am wondering if you could share some information with us. What I am looking for is a dump of your menu and your server info. You can get all of this by executing /dm <menu_name>.

FakEEE14 commented 3 months ago

it's just parsing a placeholder when i open a menu with open_commands it's pop this error because the placeholder is empty and it's return null like open_commands:

iGabyTM commented 3 months ago

Do you still get this error @FakEEE14 ? ClickActionTask.java:87 is not even the code for the placeholder action 🤷🏼

FakEEE14 commented 3 months ago

i didn't use the newst build right now, i use it and update you with that

BlitzOffline commented 2 months ago

Closing this issue because I was not able to recreate. Also, from the stacktrace, another thing seems to be causing the problem. The MenuHandler is null. My best guess at the moment is that something broke before parsing the placeholder, maybe even from a different placeholder and this is just a side effect of that.

If you manage to recreate this issue, please reopen this ticket and put the full server logs with it. Thanks.