Helsinki-NLP / OPUS-MT-train

Training open neural machine translation models
MIT License
318 stars 40 forks source link

Minor make fixes #29

Closed Traubert closed 3 years ago

Traubert commented 3 years ago

There are two commits here, one of which is just a typo fix, the other I'm not sure about. Should have made two branches I guess.. The problem is that variable definitions in eg. lib/config.mk use many of the commands defined in lib/env.mk and that are built there in the case of make install. So to avoid that failing, the make install target needs to be defined first. Or maybe it should be in lib/env.mk itself? make install still fails for me, but this is one step.