search

Helveg / jekyll-gfm-admonitions

Jekyll plugin for GitHub flavored Markdown admonition syntax
MIT License
1 stars 1 forks source link

Jekyll old version dependency #3

Open VirrageS opened 1 month ago

VirrageS commented 1 month ago

This plugin seems to be quite new but depends on Jekyll v3.0.0 which is 9 years old. Currently, they have v4.3.4. Is there a reason why this plugin requires on old version?

Helveg commented 1 month ago

Oh, I must've made a mistake there. It does seem like GitHub Pages uses Jekyll 3.10 by default? Is that correct? I'll take a look to update this to v4

VirrageS commented 1 month ago

Oh, you are right! So you wanted to support this for GitHub pages, sounds reasonable. And yes they are using 3.10 by default.

I'm no Ruby guy. Is there way to support both 3.X and 4.X?

Helveg commented 4 weeks ago

That's what I'm planning to look in to, sadly I'm a bit swamped and my laptop broke so things are a mess right now :) There's a sample included in this repo, if you can get it to build with both Jekyll 3 and Jekyll 4, then I can simply change gem 'jekyll', '~>3.0' to gem 'jekyll', '>=3.0', '<5.0' in the specfile and publish a new version.