F-Droid inclusion - Githubissues

shuvashish76 commented 3 weeks ago

Hello, would you consider publishing the app on F-Droid please? Documentation : https://gitlab.com/fdroid/fdroiddata/blob/master/CONTRIBUTING.md

HemantKArya commented 2 weeks ago

Hi @shuvashish76 thanx for suggesting this idea. However, I remember for once in the past I tried to search for docs for flutter specific and it was somewhat not able to clear my mind about how to ready a CI/CD like pipeline for flutter apps. Since it is easy to publish one APK but for continuous integration it was bit unclear to me (when I read about it few months ago.). So, if you have any clearance or any guide for flutter specific then please share it here. I am leaving this issue open if anyone have any suggestion or PR related to this then please discuss it here I will always welcome for that here.

shuvashish76 commented 2 weeks ago

ping @linsui for help

linsui commented 2 weeks ago

See the template in https://gitlab.com/fdroid/fdroiddata/-/blob/master/templates/build-flutter.yml. We can extract the flutter version from https://github.com/HemantKArya/BloomeeTunes/blob/main/.github/workflows/main.yml#L25.

HemantKArya commented 2 weeks ago

Thank you so much @linsui it's great to have help from you. Since I am new to this, I want to ask that do i have to public my app signing keys in build file or is there any way to use them during build process using env keys?

linsui commented 2 weeks ago

No, we don't use your key in any way.

HemantKArya commented 2 weeks ago

https://gitlab.com/HemantKArya/fdroiddata/-/blob/master/metadata/ls.bloomee.musicplayer.yml this is what I come up with if it is possible to help then please guide me and also how to use my keys to sign app. also is there any doc related to how to extract the version code and version from latest tags or if anything wrong with this setup draft I made.

linsui commented 2 weeks ago

The version name and version code should be extracted from https://github.com/HemantKArya/BloomeeTunes/blob/main/pubspec.yaml#L19, i.e.,

UpdateCheckData: pubspec.yaml|version:\s.+\+(\d+)|.|version:\s(.+)\+

and please check the pubspec.lock file into the repo.

HemantKArya commented 2 weeks ago

i get it that you want the version code to be from pubspec.yml. but my version code is the number which is used from the github action workflow run number. And my build number in pubspec.yml file is always have build number 0 it is updated by the github action workflow command when app is built using command flutter build like in this workflow https://github.com/HemantKArya/BloomeeTunes/blob/1af0475e675b72486dc0d172ae7cff9dbaa7bc13/.github/workflows/main.yml#L49 .

and if use the build number again from 0 then when someone update the app it will say the app is either old or corrupted. So is there any way to you suggest for this scenario.

Another doubt is that I sign my app with my own personal keys which are already saved at github workflow env, so they all are automatic built and released when new commits are pushed. How to replicate this pipeline. If I can't use private keys to sign app then should I consider publishing my app with different public keys so that everyone can sign using those keys?

linsui commented 2 weeks ago

Then you can put the build number in a file published along with the apk so that we can extract it, e.g., build-number.txt. We sign the apk with out own key, or use your signature if reproducible build is enabled. See https://f-droid.org/docs/Reproducible_Builds/.

HemantKArya commented 2 weeks ago

Thanx you so much for replying @linsui, This is what i came up with extracting the signature and uploaded to fdroiddata repo at https://gitlab.com/HemantKArya/fdroiddata/-/tree/master/metadata/ls.bloomee.musicplayer/signatures/140

and the yml file: https://gitlab.com/HemantKArya/fdroiddata/-/blob/master/metadata/ls.bloomee.musicplayer.yml

now the problem is

I want to publish the universal APK but its size is appox ~ 39 mb, will it be any problem.
do you mean publishing the built-number.txt in my release tags? and automatically extracted from there?
If it is fine for you will have a look on this yml file and is it ready for automatic buildings?

linsui commented 2 weeks ago

Do note that if you extract the signature, you need to upload it to fdroiddata manually for every version. If you use Binaries instead it can be updated automatically.

I want to publish the universal APK but its size is appox ~ 39 mb, will it be any problem.

Why not publish the splitted apks?

do you mean publishing the built-number.txt in my release tags? and automatically extracted from there?

Yes.

If it is fine for you will have a look on this yml file and is it ready for automatic buildings?

We can do that in an MR. :) It still needs some midification.

HemantKArya commented 2 weeks ago

Okay then if put binaries link in yml file then it will automatically extract the signature from it, If I understood correctly.

Why not publish the splitted apks?

because the splited variants have different build number basically it is intended behaviour added by Google itself in App Builder so that's why I wanted to use the default universal APK with default build number that is passed during building. like the variants have build number n+2000 or n+1000 according to how it is set under the hood, while the main one have original build number n.

We can do that in an MR. :) It still needs some modification.

Thanx you so much 😊 @linsui.

I will update my main.yml workflow to create file in release with name build-number.txt with content having build number.

linsui commented 2 weeks ago

F-Droid supports split abi. You just need to change the version code scheme. See https://github.com/nfcim/nfsee/blob/1302225df144a2747ecc8130bf43edee2440f1a4/android/app/build.gradle#L99 for example.