search

Hemanthhari2000 / todo-app-ports-and-adapters

2 stars 0 forks source link

[OTHER] - Module Dependency Query #1

Open dmc1899 opened 5 days ago

dmc1899 commented 5 days ago

What would you like to share?

Hi there,

I was reading your recent blog https://hemanthhari2000.medium.com/the-ports-and-adapters-pattern-unraveling-the-mystery-2efbf678ab9b and took a look at your code and have a question.

In your service.py inside your domain you have this line https://github.com/Hemanthhari2000/todo-app-ports-and-adapters/blob/3d8b8e1a1549c291b1f9c73b53499ada7bd5c272/src/domain/todo/service.py#L11 which explicitly creates a dependency on your TodoAdapter.

Does dependency not break the entire premise of having the domain not depend on the outside world (i.e. the adapters)?

Additional information

No response

Would you like to work on this issue?

Code of Conduct

dmc1899 commented 12 hours ago

I also think that the image you have published here is incorrect - https://miro.medium.com/v2/resize:fit:720/format:webp/1*qQNw52pWUE-l4Kf9MnIbIQ.png

This image implies that an Adapter implements a Port on the Driving side of the Hexagon.

Adapters use ports on the Driving side and implement ports on the Driven side.