search

Hemario / Ovale_TankScripts

Custom tank scripts for Ovale (wow)
2 stars 3 forks source link

Guardian Druid Ironfur Usage #8

Closed tehmufifnman closed 3 years ago

tehmufifnman commented 5 years ago

Ironfur doesn't have charges anymore (hasn't in quite awhile), so I think the references to SpellCharges() seem erroneous.

Multiple uses of Ironfur also stack their effect, so unless healing is needed Ironfur should be suggested. It should not be waiting to tell you to cast Ironfur until a single stack is about to fall off.

Hemario commented 5 years ago

Indeed, the SpellCharges(ironfur) is obsolete, but doesn't really affect anything.

About multiple uses of ironfur. This is kinda up to the tank to decide whether he wants to dump rage into ironfur or into maul. The ivy veins guide also mentions this on the rotation page:

Armor is extremely effective at reducing Physical damage intake, and as a result, having at least 1 stack of Ironfur Icon Ironfur up as often as possible is recommended. Additionally, you will occasionally want to pool your Rage in order to put up multiple stacks of Ironfur for a short period of time to deal with a spike in damage. There is a hard limit to how much Armor can reduce your incoming damage by, at 85%. This is unlikely to be reachable with any real consistency outside of Bristling Fur Icon Bristling Fur, but it is worth noting.

So, we want to keep at least 1 stack up at all times, after that it's up to the player to decide what he wants to do with his rage.

tehmufifnman commented 5 years ago

Oh totally - I know all about the mechanics of a Guardian Druid - and I agree, it should be up to the player - but your script takes the direction of Maul always (so maybe make it a toggle or some other solution)

Because of the BuffExpires() call on this line: if (IncomingDamage(5 physical=1) and (BuffExpires(ironfur 1) or RageDeficit() <= 20))

Hemario commented 5 years ago

It takes the direction of Maul because I check RageDeficit() <= 20 for both actions. I agree that it can be a bit annoying when you're following the dps rotation and find yourself without rage for the next ironfur cuz you used it on Maul.

What would be an alternative?

tehmufifnman commented 5 years ago

Maybe a toggle? If I am tanking raid progression I am never going to use the DPS rotation.

That or a secondary small box for defensive rotation or something?

On Mon, Aug 19, 2019 at 3:12 PM Kevin De Smet notifications@github.com wrote:

It takes the direction of Maul because I check RageDeficit() <= 20 for both actions. I agree that it can be a bit annoying when you're following the dps rotation and find yourself without rage for the next ironfur cuz you used it on Maul.

What would be an alternative?

  • Don't check the BuffExpires(ironfur 1)? Basically ironfur will always light up when we have rage. It is to the player to decide if he uses ironfur or not? Maul will still be proposed when we're about to cap rage.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Hemario/Ovale_TankScripts/issues/8?email_source=notifications&email_token=AADKUXGESDXKOZPLRWLPEJLQFMLD5A5CNFSM4IITILO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4UOLBY#issuecomment-522773895, or mute the thread https://github.com/notifications/unsubscribe-auth/AADKUXBLH67E2D3TIBEJGPDQFMLD5ANCNFSM4IITILOQ .