search

HemendraKhatik / Memory-Game

4 stars 8 forks source link

Cube changes #19

Closed NirajSrivastava18 closed 4 years ago

NirajSrivastava18 commented 4 years ago

changes made in cube light mode and dark mode cubes changes added cube

HemendraKhatik commented 4 years ago

@NirajSrivastava18 your design is not mobile responsive please make it mobile responsive as well.

NirajSrivastava18 commented 4 years ago

Hello Sir,

Making animated CSS responsive is bit difficult for me.

You can merge the PR and raise it as an issue.

Best regards,

Niraj

On Fri, 2 Oct 2020, 12:12 am AamChora, notifications@github.com wrote:

@NirajSrivastava18 https://github.com/NirajSrivastava18 your design is not mobile responsive please make it mobile responsive as well.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HemendraKhatik/Memory-Game/pull/19#issuecomment-702325846, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM7NHZCQEYTZ7GHVL2R2ICDSITEQ3ANCNFSM4SAZDQQQ .

HemendraKhatik commented 4 years ago

Hello Sir, Making animated CSS responsive is bit difficult for me. You can merge the PR and raise it as an issue. Best regards, Niraj … On Fri, 2 Oct 2020, 12:12 am AamChora, @.***> wrote: @NirajSrivastava18 https://github.com/NirajSrivastava18 your design is not mobile responsive please make it mobile responsive as well. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM7NHZCQEYTZ7GHVL2R2ICDSITEQ3ANCNFSM4SAZDQQQ .

@NirajSrivastava18 just make tiles and plane a little bit smaller use media queries to do that and make font- size smaller as well. let me know if you face any difficulty. I'll guide you.

NirajSrivastava18 commented 4 years ago

Okay I'll try

On Fri, 2 Oct 2020, 11:46 am AamChora, notifications@github.com wrote:

Hello Sir, Making animated CSS responsive is bit difficult for me. You can merge the PR and raise it as an issue. Best regards, Niraj … <#m7370144180806490311> On Fri, 2 Oct 2020, 12:12 am AamChora, @.***> wrote: @NirajSrivastava18 https://github.com/NirajSrivastava18 https://github.com/NirajSrivastava18 your design is not mobile responsive please make it mobile responsive as well. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19 (comment) https://github.com/HemendraKhatik/Memory-Game/pull/19#issuecomment-702325846>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM7NHZCQEYTZ7GHVL2R2ICDSITEQ3ANCNFSM4SAZDQQQ .

@NirajSrivastava18 https://github.com/NirajSrivastava18 just make tiles and plane a little bit smaller use media queries to do that and make font- size smaller as well. let me know if you face any difficulty. I'll guide you.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HemendraKhatik/Memory-Game/pull/19#issuecomment-702547302, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM7NHZBXTNJ6HEEKENK4D6TSIVV2ZANCNFSM4SAZDQQQ .

NirajSrivastava18 commented 4 years ago

Hello Sir,

Thank you very much for your guidance and support over making the cube responsive

I have made the cube responsive and created a new PR. Please review the same.

Best regards,

Niraj Srivastava

On Fri, 2 Oct 2020, 12:34 pm Niraj Srivastava, < nirajsrivastava2001@gmail.com> wrote:

Okay I'll try

On Fri, 2 Oct 2020, 11:46 am AamChora, notifications@github.com wrote:

Hello Sir, Making animated CSS responsive is bit difficult for me. You can merge the PR and raise it as an issue. Best regards, Niraj … <#m_5786368397048777843_m7370144180806490311> On Fri, 2 Oct 2020, 12:12 am AamChora, @.***> wrote: @NirajSrivastava18 https://github.com/NirajSrivastava18 https://github.com/NirajSrivastava18 your design is not mobile responsive please make it mobile responsive as well. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19 (comment) https://github.com/HemendraKhatik/Memory-Game/pull/19#issuecomment-702325846>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM7NHZCQEYTZ7GHVL2R2ICDSITEQ3ANCNFSM4SAZDQQQ .

@NirajSrivastava18 https://github.com/NirajSrivastava18 just make tiles and plane a little bit smaller use media queries to do that and make font- size smaller as well. let me know if you face any difficulty. I'll guide you.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HemendraKhatik/Memory-Game/pull/19#issuecomment-702547302, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM7NHZBXTNJ6HEEKENK4D6TSIVV2ZANCNFSM4SAZDQQQ .