search

HemmeligOrg / Hemmelig.app

Keep your sensitive information out of chat logs, emails, and more with encrypted secrets.
https://hemmelig.app
MIT License
697 stars 61 forks source link

Add Dutch locale #212

Closed ltguillaume closed 1 year ago

ltguillaume commented 1 year ago

I saw that some back-end stuff is not yet translatable.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

bjarneo commented 1 year ago

I saw that some back-end stuff is not yet translatable.

Yes, that is true. I think several things in the frontend hasn't been updated to be translated either.

Thanks for this PR :)

ltguillaume commented 1 year ago

@bjarneo I just updated the docker image, double-checked that the Dutch locale was present in the image, then fired up the browser: the interface sticks to English somehow. Tested in Chromium and LibreWolf.

SECRET_FORCED_LANGUAGE=nl doesn't do the trick either.

ltguillaume commented 1 year ago

Doesn't work either. I also tried to set SECRET_FORCED_LANGUAGE=de for German. No go.

bjarneo commented 1 year ago

@bjarneo I just updated the docker image, double-checked that the Dutch locale was present in the image, then fired up the browser: the interface sticks to English somehow. Tested in Chromium and LibreWolf.

SECRET_FORCED_LANGUAGE=nl doesn't do the trick either.

Hm, then we have a bug, for sure. The SECRETD_FORCED_LANGUAGE should have done the trick. I mean

https://github.com/HemmeligOrg/Hemmelig.app/blob/bd17097e57b23af88c8f3c08f14a40dde0f22951/src/i18n.js#L8C1-L21 this logic sets the fallback language.

I will have a look at it. I do not have time today though.