search

HemmeligOrg / Hemmelig.app

Keep your sensitive information out of chat logs, emails, and more with encrypted secrets.
https://hemmelig.app
MIT License
684 stars 59 forks source link

fix: added error checks on account routes #231

Closed m4-droid closed 10 months ago

m4-droid commented 10 months ago

fixes #211 : added loader on every route like /account : added success notification on some routes : added specific notification message upon deletion success : added extra checks for routes : added more descriptive variable names : added redirect to /signout upon account deletion : added general timeout of 2.5s on success notification : other fixes -- : error: isLoggedIn: true was dispatched due to delay in clearing cookie & calling getCookie() in useEffect() of Header -- : fix: added await for async call of signOut() in useEffect() of SignOut component

m4-droid commented 10 months ago

I am not sure error mentioned in other fixes is general or specific to me (used chrome browser).

m4-droid commented 10 months ago

I am working on this code duplication issue in SonarCloud Quality Gate test. If anything else is concerning in code or any suggestion related to reducing code duplication or adding something in code, let me know.

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

bjarneo commented 10 months ago

Thank you. I will look into this PR as soon as I have some spare time :)

m4-droid commented 10 months ago

It would be great if you could review this before Hacktoberfest ends.