HemmeligOrg / Hemmelig.app

Keep your sensitive information out of chat logs, emails, and more with encrypted secrets.
https://hemmelig.app
MIT License
681 stars 57 forks source link

- Add missing translations to account/users & signin routes #281

Closed ltguillaume closed 4 months ago

ltguillaume commented 5 months ago

Notes

  1. I have inferred the proper use of quotes and double quotes from the rest of the code, but haven't built the app, so this needs to be double-checked.
  2. I've used the new structure in the translation files to mirror the routes (e.g. admin.users.role), but a lot of the old strings that are used only under e.g. admin.users are still in users. I suppose this is easier to refactor in your IDE than it is for me to do this manually.
sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

ltguillaume commented 4 months ago

No dice?

bjarneo commented 4 months ago

@ltguillaume We should get this merged. Have not have time to look into this yet.

ltguillaume commented 4 months ago

@ltguillaume We should get this merged. Have not have time to look into this yet.

Yeah I just created a new PR based on the updated code.