Review

[dajare]

Typography etc.

• [x] accept modernize-spelling changes, except (I think!) Roumanians and shew in c4 (in a context of many "misspellings"; I might well be wrong here, though).
• [x] se clean makes a change to se-lint-ignore.xml which should be accepted.
• [x] mismatched-dashes gives: ʻng-ʻngah (1) ʻngʻngah (1) which looks like it should be normalized.
• [x] c3 / line 51 | the Editorial changes to capitalization: I note Vince's advice in the forum on this; I wonder, though whether ye ought to go to Ye, since that's simply archaic "the" which would not normally be capitalized here. Maybe Alex needs to check this one.
• [x] c3 / line 51 | wrong punctuation order after "Esq.": ”, “or -> ,” “or.

Semantics/markup

• [x] Semantics c3 / line 19 some issues: <abbr epub:type="z3998:given-name">G. B.</abbr>should be personal-name; I think the rest of the given-name semantics in this paragraph ought to be surname
• [x] c5 / line 100 | such words as <em>Sabaoth</em>, <em>Metraton</em>, <em>Almonsin</em>, and <em>Zariatnatmik</em> : these were italics in the scans, but are neither italics nor emphasized text for SE, and should go into “...” in an [Editorial] commit.

Images

• [x] Cover image is 2.6Mb! And it's got quite a bit of "noise". I tried some subtle de-noising, and compressed the JPEG down to 465Kb - you can download from here (or try yourself!), and then rebuild images.
• [x] Other images : the images in the ./images directory should be the source PNG or JPG files used to create the SVGs, not the SVGs themselves. (They are already in src/epub/images/*.svg.)
• [x] There is no loi.xhtml file, so this needs to be created. That needs to go in the mainfest, spine, and ToC, so it will need to be rebuilt, too.

local.css / metadata

• [x] local.css Normally rules pertaining to one "type" of presentation should be grouped together; here you have "letter" semantics at a couple different places. It's also "best practice" to have signals for starting/ending these groups in /* ... */ lines - here's a good random example.
• [On the rules themselves, I'm genuinely unsure, so I'll flag this for Alex who would review them anyway.]
• [x] content.opf | the marc:relator ill should be added to Lovecraft's roles
• [x] long description : a couple typo fixes:
  • geneological -> genealogical
  • man whom Ward discovers to be related to. -> man to whom Ward discovers he is related.

Rebasing

• [x] 861b870 has a spelling mistake in the commit message (Bibliot~ > Biblioth~ ×2); if you're comfortable rebasing that with the correct spelling, that would be good as this is an Editorial commit.
• [x] d5e6bb0 likewise has a spelling mistake in Editorial commit message disti-house should be distil-house.
• [x] 435cc45 fixing transcriber mistakes (like this omission) is not Editorial, though, so this commit can have the [Editorial] prefix removed.

(Each of those is just renaming, so hopefully fairly simple as far as rebase tasks go.)

[dajare]

• [x] This correction didn't quite go far enough : Ward discovers to be related to. -> Ward discovers he is related.
• [x] It looks like you should run se clean . one more time, and commit any changes it makes. If it makes no changes, it's me, so not to worry!

I think/hope that's it (from me, anyway).

[dajare]

Hendrik - that troublesome :) sentence in the long desc needs to end: ...he is related. (Still has "to" at the end!) Could you fix that (another rebase?!), and I'll pass it along to Alex. Thanks!

[HendrikBK]

I end not being able to make a rebase (I didn't have access to my linux machine that I'm used to). So I end up making a pull request by accident on windows. Is this acceptable? If not I'll fix it later.

[dajare]

That looks fine to me! No need for a rebase with this one, I'm sure. I'll send along to Alex now.