Hendrix-Shen / MagicLib

To beat magic with magic :(
https://www.curseforge.com/minecraft/mc-mods/magiclib
GNU Lesser General Public License v3.0
80 stars 13 forks source link

[Bug] 在其它不使用magiclib制作的carpet拓展中加入了magiclib及相关拓展的版本信息 #70

Closed Crystal0404 closed 2 months ago

Crystal0404 commented 3 months ago

Minecraft Version

*

MagicLib Version

*

Description

https://github.com/TISUnion/Carpet-TIS-Addition/issues/149 基本相同

https://github.com/Hendrix-Shen/MagicLib/blob/6b6d57d7222b3b5e4223227e0fefef200f99d3ea/magiclib-legacy-compat/src/main/java/top/hendrixshen/magiclib/mixin/carpet/MixinSettingManager.java#L57-L59

这个mixin会导致magiclib的版本信息会显示在其它没有使用magiclib并且使用carpet的SettingsManager创建自己命令的拓展下面(例如carpet-fix)

屏幕截图 2024-05-24 172102

To Reproduce

  1. 安装magiclib任意版本
  2. 安装carpet-fix和carpet
  3. 使用/carpet-fixes

Expected behavior

image

Log

Latest CI build tested

github-actions[bot] commented 3 months ago

This issue is stale because it has been open for 14 days with no activity.

github-actions[bot] commented 2 months ago

This issue was closed because it has been inactive for 7 days since being marked as stale.