search

HengFuYuen / pe

0 stars 0 forks source link

Not too sure if `on exit` is required #22

Open HengFuYuen opened 3 years ago

HengFuYuen commented 3 years ago

image.png

nus-pe-bot commented 3 years ago

Team's Response

It might not be necessary to add class method, but I think it shows clarity that we are calling a static method from another class, instead of having an object of that class. The "on exit" label is to show that the method returns only when the user exits the program.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Based on the team's response, I am assuming that a static class method is called somewhere, if so perhaps a UML notation like shown in the image below should be used. However, I did not observe such a notation being used in the diagram. Therefore, I am not sure if the team might have accidentally written the response to another bug here.

image.png

Regarding the on exit, I believe that sequence diagrams perhaps do not need labels for return arrows, maybe only return values if any, and I think the notation itself is sufficiently clear even without this label.

:question: Issue severity

Team chose [severity.Low] Originally [severity.VeryLow]

Reason for disagreement: [replace this with your explanation]