search

HengShuHong / pe

0 stars 0 forks source link

Unsure if editing book at index 1 or title 1 #2

Open HengShuHong opened 5 months ago

HengShuHong commented 5 months ago

This error is a continuation of the first error that allows me to edit the book title to a number. There might be some confusion when I try to use the command edit '1' isit editing the book with title '1' or at index '1'. In the screenshot below it is the index 1 but the user might be trying to edit the book with title '1' instead

image.png image.png

nus-se-script commented 5 months ago

Team's Response

We believe this is a duplicate of #148 as it is caused by the same issue, allowing the book title to be edited into special characters or just a number without exception though the normal add feature and UG does not allow so, and can thus be fixed by fixing #148 as well.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Able to edit book title to contain special characters

As seen in the screenshot below, when I try to add a book '$$dollar' it shows an error due to special characters. However, when i try to edit the book title of an exiting book to '$$dollar' it proceeds and edits the name

image.png

[original: nus-cs2113-AY2324S2/pe-interim#134] [original labels: type.FeatureFlaw severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for your response. We accept this issue as we should have put an exception to disallow users from editing book titles to special characters.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Medium`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** initially, the severity was set to low as this problem was a continuation of a previous bug. Hence, I still believe that it should be low as it can be avoided by fixing earlier methods.