search

HengShuHong / pe

0 stars 0 forks source link

Unable to sort book title with special characters #5

Open HengShuHong opened 5 months ago

HengShuHong commented 5 months ago

In the screenshot, as I was able to add special characters to book names, it causes a weird listing by alphabetical for the book title

image.png

soc-se-bot commented 5 months ago

Team's Response

We believe this is a duplicate of #148 as it is caused by the same issue, allowing the book title to be edited into special characters without exception though the normal add feature and UG does not allow so, and can thus be fixed by fixing #148 as well.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Able to edit book title to contain special characters

As seen in the screenshot below, when I try to add a book '$$dollar' it shows an error due to special characters. However, when i try to edit the book title of an exiting book to '$$dollar' it proceeds and edits the name

image.png

[original: nus-cs2113-AY2324S2/pe-interim#134] [original labels: type.FeatureFlaw severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for your response. We accept this issue as we should have put an exception to disallow users from editing book titles to special characters.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Medium`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** severity set as low as this issue happened due to an earlier bug