HengShuHong / pe

0 stars 0 forks source link

Extending of a book does not seem to work #7

Open HengShuHong opened 6 months ago

HengShuHong commented 6 months ago

Extending a book with special characters does not seem to work even though a success message is being output

image.png

nus-pe-bot commented 6 months ago

Team's Response

We believe this is a duplicate of #1020 as it is caused by the same issue as an issue of the Extend feature and not because of special characters, and can be fixed with the same fix as well.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

extend function does not work

Previously, I made same borrow a book "book1". And when I tried to extend his borrowing, the system says it is successfully extended but it is not reflected in the list of books sorted by user.

>> borrow book1 /by sam

_______________________________________________________________________________

Borrowed book1 by sam!
Please return by 03/05/2024.

_______________________________________________________________________________
_______________________________________________________________________________

>> list /sortby user

_______________________________________________________________________________

List of Users and Borrowed Books:

User: marry
Borrowed Books:
1. Hunger Games, Borrowed on: 2024-04-19, Return by: 2024-05-10

User: tom
Borrowed Books:
1. booka, Borrowed on: 2024-04-19, Return by: 2024-05-03

User: may
Borrowed Books:
1. Booka, Borrowed on: 2024-04-19, Return by: 2024-05-03

User: sam
Borrowed Books:
1. book1, Borrowed on: 2024-04-19, Return by: 2024-05-03

_______________________________________________________________________________
_______________________________________________________________________________

>> extend book1 /by sam

_______________________________________________________________________________

The borrowing period for 'book1' has been successfully extended by one week.

_______________________________________________________________________________
_______________________________________________________________________________

>> list /sortby user

_______________________________________________________________________________

List of Users and Borrowed Books:

User: marry
Borrowed Books:
1. Hunger Games, Borrowed on: 2024-04-19, Return by: 2024-05-10

User: tom
Borrowed Books:
1. booka, Borrowed on: 2024-04-19, Return by: 2024-05-03

User: may
Borrowed Books:
1. Booka, Borrowed on: 2024-04-19, Return by: 2024-05-03

User: sam
Borrowed Books:
1. book1, Borrowed on: 2024-04-19, Return by: 2024-05-03

_______________________________________________________________________________
_______________________________________________________________________________

As show above, the return date is still 2024-05-03 after extending it. I also have tried entering the extend command for many times but the return date is never updated.


[original: nus-cs2113-AY2324S2/pe-interim#1215] [original labels: type.FunctionalityBug severity.High]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for your response. This is a valid concern and we accept it. However, we believe it should be a Medium severity instead of high as it only causes inconvenience when the user uses the extend feature, and the user can continue using every other aspect of the app without issues. Furthermore, extend is one of the less crucial functions of the app. All this fits the label tag of Medium severity

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]