search

HengShuHong / pe

0 stars 0 forks source link

Program crashes when extending a book with special characters #8

Open HengShuHong opened 6 months ago

HengShuHong commented 6 months ago

To replicate, use the add function to

  1. add a book with a valid title
  2. edit the title name to '?? Yes'.
  3. borrow the book using index
  4. enter 'extend ?? Yes /by user'

image.png

nus-pe-bot commented 6 months ago

Team's Response

We believe this is a duplicate of #148 as it is caused by the same issue, allowing the book title to be edited into special characters or just a number without exception though the normal add feature and UG does not allow so, and can thus be fixed by fixing #148 as well. Furthermore, this crash will ONLY happen if the special character is a very specific special character (such as question marks as shown above), and not for all special characters - a "!" will not crash the app, for example, due to Java issues that are out of our control.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Able to edit book title to contain special characters

As seen in the screenshot below, when I try to add a book '$$dollar' it shows an error due to special characters. However, when i try to edit the book title of an exiting book to '$$dollar' it proceeds and edits the name

image.png

[original: nus-cs2113-AY2324S2/pe-interim#134] [original labels: type.FeatureFlaw severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for your response. We accept this issue as we should have put an exception to disallow users from editing book titles to special characters.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]